Fix batch range line selector and also allow to create logs on draft commits #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresgutgon
force-pushed
the
fix/batch-rows-range-picker
branch
from
66ed99a to
4a0ea8d
Compare
csansoon
reviewed
Sep 17, 2024
csansoon
previously approved these changes
Sep 17, 2024
andresgutgon
force-pushed
the
fix/batch-rows-range-picker
branch
from
4a0ea8d to
b2f0908
Compare
geclos
reviewed
Sep 17, 2024
| options={providerOptions} | ||
| value={selectedProvider} | ||
| disabled={ | ||
| disabledMetadataSelectors || isLoading || !providerOptions.length | ||
| } |
There was a problem hiding this comment.
does the placeholder show when disabled? we should tell the user they are using the default provider if none selected
There was a problem hiding this comment.
If non selected it says "default provider" yes
geclos
reviewed
Sep 17, 2024
| @@ -43,7 +47,7 @@ export const runBatchEvaluationJob = async ( | |||
| if (!workspace) throw new NotFoundError('Workspace not found') | |||
|
|
|||
| const commit = await new CommitsRepository(workspace.id) | |||
| .find(document.commitId) | |||
There was a problem hiding this comment.
I don't get this, how can document.commitid be different than commitUuid? the documentversion always poins to its commit no?
There was a problem hiding this comment.
Before it was the commitId the document was created (live). Now is the commit that the user is seeing. live or a draft commit. So, the logs are attached to that commit. Which is what we want
geclos
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Line picker selector was not working properly
Issue: #180
🐛 Evaluation logs not created on DRAFT commits
While fixing the batch line range selector we saw that evaluation logs where not created when in a draft commit. The reason is that we were enqueueing jobs with
document.commitIdinstead of draft commit id. Now we passcommitUuidthat is in the URL of the draft commit.What?