Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: api key settings section #197

Merged
merged 1 commit into from
Sep 17, 2024
Merged

feature: api key settings section #197

merged 1 commit into from
Sep 17, 2024

Conversation

geclos
Copy link
Collaborator

@geclos geclos commented Sep 17, 2024

No description provided.

@geclos geclos force-pushed the feature/apikeys_settings branch from b8f5604 to 7700844 Compare September 17, 2024 12:29
@geclos geclos force-pushed the feature/apikeys_settings branch from 7700844 to 927e543 Compare September 17, 2024 12:40

export async function destroyApiKey(apiKey: ApiKey, db = database) {
return Transaction.call(async (trx) => {
await trx.delete(apiKeys).where(eq(apiKeys.id, apiKey.id))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You check in frontend. But in backend do we check if it's last API key?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 good point

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will add it a future pr

@geclos geclos force-pushed the feature/apikeys_settings branch from 927e543 to 50011ef Compare September 17, 2024 13:23
@geclos geclos merged commit 2995cb6 into main Sep 17, 2024
3 checks passed
@geclos geclos deleted the feature/apikeys_settings branch September 17, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants