Setup websockets communication between web and workers #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresgutgon
commented
Sep 14, 2024
| @@ -45,6 +45,18 @@ export const runEvaluationJob = async (job: Job<RunEvaluationJobData>) => { | |||
| } | |||
|
|
|||
| await progressTracker.incrementErrors() | |||
| } finally { | |||
| await progressTracker.decrementTotal() | |||
There was a problem hiding this comment.
decrementTotal was only in the catch but I think is something we want to do always no?
Also I think we could make decrementTotal private and run it inside increamentErrors and the other method for success
There was a problem hiding this comment.
hmm no we only wanna do it when there's an error, if we succeed we don't wanna decrement the total
andresgutgon
commented
Sep 14, 2024
apps/web/package.json
Outdated
| @@ -27,10 +27,12 @@ | |||
| "@sentry/nextjs": "^8", | |||
| "@t3-oss/env-nextjs": "^0.10.1", | |||
| "ai": "^3.2.42", | |||
| "socket.io-react-hook": "^2.4.5", | |||
There was a problem hiding this comment.
Not very complicated to integrate but this package is small and nice
andresgutgon
force-pushed
the
feature/spike-websockets
branch
4 times, most recently
from
caced6f to
dbaacf8
Compare
andresgutgon
commented
Sep 15, 2024
apps/web/package.json
Outdated
| @@ -42,6 +43,8 @@ | |||
| "nprogress": "^0.2.0", | |||
| "react": "19.0.0-rc-f994737d14-20240522", | |||
| "react-dom": "19.0.0-rc-f994737d14-20240522", | |||
| "socket.io-client": "^4.7.5", | |||
There was a problem hiding this comment.
🔥 Included in the hook
andresgutgon
commented
Sep 15, 2024
andresgutgon
commented
Sep 15, 2024
andresgutgon
commented
Sep 15, 2024
| token, | ||
| cookiesOptions: { | ||
| secure: isProd, | ||
| domain: isProd ? `.${env.APP_DOMAIN}` : 'localhost', |
There was a problem hiding this comment.
CORS for all the subdomains of the app domain. This way we can share cookies between web client and websockets server as auth method
andresgutgon
force-pushed
the
feature/spike-websockets
branch
2 times, most recently
from
61e7179 to
6921e29
Compare
andresgutgon
force-pushed
the
feature/spike-websockets
branch
3 times, most recently
from
7d7f57c to
2e282eb
Compare
We want to keep the client informed when evaluations are running. How many logs are created and how many logs fail. This PR setup a new Express server that setup a Socket.IO websocket server with 2 endpoints /websocket and worker-websocket. The one for web has secure cookies token auth and the one for workers share a secret token between Sockets server and workers. I think this setup makes sense
andresgutgon
force-pushed
the
feature/spike-websockets
branch
from
2e282eb to
6ece440
Compare
geclos
reviewed
Sep 16, 2024
| @@ -23,5 +24,6 @@ export default createEnv({ | |||
| GATEWAY_HOSTNAME: process.env.GATEWAY_HOSTNAME, | |||
| GATEWAY_PORT: process.env.GATEWAY_PORT, | |||
| GATEWAY_SSL: process.env.GATEWAY_SSL, | |||
| WEBSOCKETS_SERVER: process.env.WEBSOCKETS_SERVER, | |||
There was a problem hiding this comment.
It's on packages/env/src/index.ts
geclos
reviewed
Sep 16, 2024
geclos
reviewed
Sep 16, 2024
websockets until infra is ready
andresgutgon
force-pushed
the
feature/spike-websockets
branch
from
a42ff43 to
9c43369
Compare
geclos
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
We want to keep the client informed when evaluations are running. How many logs are created, and how many logs fail
This PR set up a new Express server that set up a Socket.IO websocket server with 2 endpoints /websocket and worker-websocket. The one for the web has secure cookies token auth and the one for workers share a secret token between Sockets server and workers.
I think this setup makes sense
Screen.Recording.2024-09-16.at.13.56.54.mov
TODO
webwhen user login with magic link.<WebsocketsProvider />in React client so it can start listening to eventsWEBWORKERStotalis 0? REVIEW thislogoutlol we didn't have itlogoutNext PR
wsorwss(Secure). Maybe is not necessary because is behind a proxy cc @geclos