Evaluation results dashboard #170
Conversation
csansoon
added
the
🚂 lil train
csansoon
force-pushed
the
evaluation-results-dashboard
branch
from
a7de50b to
5ddedf8
Compare
| children?: ReactNode | ||
| }) { | ||
| const panel = ( | ||
| <div className='min-w-44 flex-1 h-[84px] flex flex-col gap-1 p-4 rounded-lg border border-border'> |
There was a problem hiding this comment.
Try to avoid hardcoding all these values for width and height
| <Text.H3B> | ||
| {mostCommonResult}{' '} | ||
| <Text.H3 color='foregroundMuted'>({resultPresence} %)</Text.H3> | ||
| </Text.H3B> |
There was a problem hiding this comment.
This is weird no? I text wrapping a text
There was a problem hiding this comment.
This way I was avoiding using two text components under a <>{…}</>. It's the same thing anyways, I'll use this instead.
| <div className='flex gap-6 flex-wrap'> | ||
| <div className='h-[192px] min-w-[300px] flex-1 bg-muted-foreground rounded-lg' /> | ||
| <div className='h-[192px] min-w-[300px] flex-1 bg-muted-foreground rounded-lg' /> | ||
| <div className='min-w-[400px] flex-1'> |
There was a problem hiding this comment.
In this case this is a placeholder while the actual charts are being developed.
| table={<></>} | ||
| /> | ||
|
|
||
| <MetricsSummary |
There was a problem hiding this comment.
Why not inside table from TableWithHeader?
There was a problem hiding this comment.
idk, feels misleading using the table attribute for non-table components...
| export const getEvaluationByIdCached = cache(async (id: number) => { | ||
| const { workspace } = await getCurrentUser() | ||
| const evaluationScope = new EvaluationsRepository(workspace.id) | ||
| const result = await evaluationScope.findById(id) |
There was a problem hiding this comment.
all repos implement find method which is == to this findById so we can probably remove this one
csansoon
force-pushed
the
evaluation-results-dashboard
branch
4 times, most recently
from
0e3ed2f to
9b8ff60
Compare
csansoon
force-pushed
the
evaluation-results-dashboard
branch
from
9b8ff60 to
ebdf5f8
Compare
TRENECITO: Graphs will be added in a next PR.
Also missing:
evaluationResults.providerLogIdcurrently points to the last provider log of the document log that is being evaluated. Instead, this should point to the provider log that has been generated through the evaluation, the one that sets the value ofevaluationResults.result