Dataset preview data #143
Merged
Dataset preview data #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresgutgon
commented
Sep 6, 2024
| import { syncReadCsv } from '../../lib/readCsv' | ||
|
|
||
| /** | ||
| * This service pick the first N rows of a CSV file |
There was a problem hiding this comment.
csv lib we use also has from so we can implement some kind of pagination in the future
andresgutgon
force-pushed
the
feature/dataset-previews
branch
from
1aab329 to
9ffc6f6
Compare
andresgutgon
force-pushed
the
feature/datasets-data-model
branch
from
ee4887c to
c026196
Compare
andresgutgon
force-pushed
the
feature/dataset-previews
branch
from
9ffc6f6 to
084805a
Compare
andresgutgon
force-pushed
the
feature/dataset-previews
branch
from
e50fcc4 to
a462d73
Compare
andresgutgon
force-pushed
the
feature/dataset-previews
branch
from
a462d73 to
089b834
Compare
csansoon
reviewed
Sep 9, 2024
Comment on lines
24
to
25
| const MAX_SIZE = 3 | ||
| const MAX_UPLOAD_SIZE_IN_MB = 3 * 1024 * 1024 |
There was a problem hiding this comment.
Nitpicking but use MAX_SIZE to calculate MAX_SIZE_IN_MB
There was a problem hiding this comment.
No good catch 💯 . This needs to be changed to 15MB now. I forgot thanks
csansoon
reviewed
Sep 9, 2024
Comment on lines
+46
to
+49
| csvDelimiter: z.enum(DELIMITERS_KEYS, { | ||
| message: 'Choose a valid delimiter option', | ||
| }), | ||
| csvCustomDelimiter: z.string(), |
There was a problem hiding this comment.
Shouldn't csvCustomDelimiter be optional?
There was a problem hiding this comment.
It's ok, we always send an empty string because the field is always sent. Is in the validation that we check user picked custom and this field has content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Preview dataset CSV data
TODO