feat: wip

apps/web/src/app/api/projects/[projectId]/documents/[documentUuid]/logs/route.ts

@@ -1,23 +1,10 @@
-import {
-  DEFAULT_PAGINATION_SIZE,
-  LogSources,
-  Workspace,
-} from '@latitude-data/core/browser'
+import { Workspace } from '@latitude-data/core/browser'
 import { computeDocumentLogsQuery } from '@latitude-data/core/services/documentLogs/computeDocumentLogs'
 import { computeDocumentLogsWithMetadataQuery } from '@latitude-data/core/services/documentLogs/computeDocumentLogsWithMetadata'
 import { authHandler } from '$/middlewares/authHandler'
 import { errorHandler } from '$/middlewares/errorHandler'
 import { NextRequest, NextResponse } from 'next/server'
-import { decodeParameters } from '$/services/helpers'
-
-function parsePage(page: string | null): string {
-  if (!page) return '1'
-
-  const parsed = parseInt(page, 10)
-  if (isNaN(parsed)) return '1'
-
-  return parsed < 1 ? '1' : parsed.toString()
-}
+import { parseApiDocumentLogParams } from '@latitude-data/core/services/documentLogs/index'
 
 export const GET = errorHandler(
   authHandler(
@@ -36,41 +23,22 @@ export const GET = errorHandler(
     ) => {
       const { documentUuid } = params
       const searchParams = req.nextUrl.searchParams
-      const excludeErrors = searchParams.get('excludeErrors') === 'true'
-
-      const page = parsePage(searchParams.get('page'))
-      const pageSize =
-        searchParams.get('pageSize') ?? String(DEFAULT_PAGINATION_SIZE)
-
-      const { commitIds: _commitIds, logSources: _logSources } =
-        decodeParameters(req.nextUrl.search)
-      const commitIds = (Array.isArray(_commitIds) ? _commitIds : [_commitIds])
-        .filter((c) => c !== undefined)
-        .map(Number)
-
-      const logSources = (
-        Array.isArray(_logSources) ? _logSources : [_logSources]
-      ).filter((l) => l !== undefined) as LogSources[]
-
-      const filterOptions = {
-        commitIds,
-        logSources,
-      }
+      const queryParams = parseApiDocumentLogParams({ searchParams })
 
-      if (!filterOptions.commitIds.length || !filterOptions.logSources.length) {
+      if (queryParams.isEmptyResponse) {
         return NextResponse.json([], { status: 200 })
       }
 
-      const buildQueryFn = excludeErrors
+      const buildQueryFn = queryParams.excludeErrors
         ? computeDocumentLogsQuery
         : computeDocumentLogsWithMetadataQuery
 
       const rows = await buildQueryFn({
         workspaceId: workspace.id,
         documentUuid,
-        filterOptions,
-        page,
-        pageSize,
+        filterOptions: queryParams.filterOptions,
+        page: queryParams.page,
+        pageSize: queryParams.pageSize,
       })
 
       return NextResponse.json(rows, { status: 200 })

apps/web/src/services/helpers.ts

@@ -23,21 +23,3 @@ export function addParameters(
 
   return `${path}?${params.join('&')}`
 }
-
-export function decodeParameters(route: string): Record<string, UriParam> {
-  const [_, query] = route.split('?')
-  if (!query) return {}
-
-  const params = query.split('&')
-  return params.reduce((acc: Record<string, UriParam>, param: string) => {
-    const [key, value] = param.split('=')
-    if (!key || !value) return acc
-    if (value.includes(',')) {
-      return {
-        ...acc,
-        [key]: value.split(',').map(decodeURIComponent),
-      }
-    }
-    return { ...acc, [key]: decodeURIComponent(value) }
-  }, {})
-}

packages/core/src/services/documentLogs/logsFilterUtils/index.ts

@@ -1 +1,2 @@
 export * from './parseLogFilterParams'
+export * from './parseApiLogFilterParams'

packages/core/src/services/documentLogs/logsFilterUtils/parseApiLogFilterParams.ts

@@ -0,0 +1,48 @@
+import { DEFAULT_PAGINATION_SIZE, LogSources } from '../../../constants'
+import { parseSafeCreatedAtRange } from './parseLogFilterParams'
+
+function parsePage(page: string | null): string {
+  if (!page) return '1'
+
+  const parsed = parseInt(page, 10)
+  if (isNaN(parsed)) return '1'
+
+  return parsed < 1 ? '1' : parsed.toString()
+}
+
+function parseCommitIds(commitIds: string | undefined) {
+  return commitIds?.split(',')?.map?.(Number) ?? []
+}
+
+function parseLogSources(logSources: string | undefined) {
+  return (logSources?.split?.(',') as LogSources[]) ?? []
+}
+
+export function parseApiDocumentLogParams({
+  searchParams,
+}: {
+  searchParams: URLSearchParams
+}) {
+  const params = Object.fromEntries(searchParams.entries())
+  const commitIds = parseCommitIds(params.commitIds)
+  const logSources = parseLogSources(params.logSources)
+  const excludeErrors = searchParams.get('excludeErrors') === 'true'
+
+  const filterOptions = {
+    commitIds,
+    logSources,
+    createdAt: parseSafeCreatedAtRange(params.createdAt),
+  }
+
+  const isEmptyResponse =
+    filterOptions.commitIds.length === 0 ||
+    filterOptions.logSources.length === 0
+
+  return {
+    excludeErrors,
+    isEmptyResponse,
+    filterOptions,
+    page: parsePage(searchParams.get('page')),
+    pageSize: searchParams.get('pageSize') ?? String(DEFAULT_PAGINATION_SIZE),
+  }
+}

packages/core/src/services/documentLogs/logsFilterUtils/parseLogFilterParams.ts

@@ -7,7 +7,9 @@ function parseLogSourcesSafe(origins: string[] | string | undefined) {
   return logSources.filter((s) => LOG_SOURCES.includes(s as LogSources))
 }
 
-function parseSafeCreatedAtRange(createdAt: string[] | string | undefined) {
+export function parseSafeCreatedAtRange(
+  createdAt: string[] | string | undefined,
+) {
   const [from, to] = createdAt?.toString()?.split(',') ?? []
   if (!from || !to) return undefined