feat: wip

latitude-dev · Sep 20, 2024 · d938d13 · d938d13
1 parent 92fbc32
commit d938d13
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 12 deletions.
diff --git a/...mentUuid]/evaluations/[evaluationId]/_components/MetricsSummary/Charts/ChartContainer.tsx b/...mentUuid]/evaluations/[evaluationId]/_components/MetricsSummary/Charts/ChartContainer.tsx
@@ -16,7 +16,7 @@ export function ChartWrapper({
   return (
     <div
       className={cn(
-        'h-[192px] min-w-[300px] flex-1 rounded-lg flex flex-col gap-2 p-2 overflow-hidden border',
+        'h-[202px] min-w-[300px] flex-1 rounded-lg flex flex-col gap-2 p-2 overflow-hidden border',
         {
           'border-border': !error,
           'border-destructive': !!error,

diff --git a/...nts/[documentUuid]/evaluations/[evaluationId]/_components/MetricsSummary/Charts/index.tsx b/...nts/[documentUuid]/evaluations/[evaluationId]/_components/MetricsSummary/Charts/index.tsx
@@ -14,11 +14,10 @@ export function EvaluationResultsCharts({
   evaluation: Evaluation
   documentUuid: string
 }) {
-  if (evaluation.configuration.type === EvaluationResultableType.Number) {
-    return (
-      <NumericalCharts evaluation={evaluation} documentUuid={documentUuid} />
-    )
-  }
+  const isNumerical =
+    evaluation.configuration.type === EvaluationResultableType.Number
 
-  return null
+  if (!isNumerical) return null
+
+  return <NumericalCharts evaluation={evaluation} documentUuid={documentUuid} />
 }
diff --git a/.../documents/[documentUuid]/evaluations/[evaluationId]/_components/MetricsSummary/index.tsx b/.../documents/[documentUuid]/evaluations/[evaluationId]/_components/MetricsSummary/index.tsx
@@ -1,7 +1,6 @@
 import { Commit, Evaluation, Workspace } from '@latitude-data/core/browser'
 
 import { BigNumberPanels } from './BigNumberPanels'
-import { BigNumberPanelsOld } from './BigNumberPanelsOld'
 import { EvaluationResultsCharts } from './Charts'
 
 export function MetricsSummary({

diff --git a/...tId]/versions/[commitUuid]/documents/[documentUuid]/evaluations/[evaluationId]/layout.tsx b/...tId]/versions/[commitUuid]/documents/[documentUuid]/evaluations/[evaluationId]/layout.tsx
@@ -1,5 +1,6 @@
 import { ReactNode, Suspense } from 'react'
 
+import { EvaluationResultableType } from '@latitude-data/core/browser'
 import { EvaluationsRepository } from '@latitude-data/core/repositories'
 import { computeEvaluationResultsWithMetadata } from '@latitude-data/core/services/evaluationResults/computeEvaluationResultsWithMetadata'
 import { TableWithHeader, Text } from '@latitude-data/web-ui'
@@ -13,6 +14,11 @@ import { Actions } from './_components/Actions'
 import { EvaluationResults } from './_components/EvaluationResults'
 import { MetricsSummary } from './_components/MetricsSummary'
 
+const TYPE_TEXT: Record<EvaluationResultableType, string> = {
+  [EvaluationResultableType.Text]: 'Text',
+  [EvaluationResultableType.Number]: 'Numerical',
+  [EvaluationResultableType.Boolean]: 'Boolean',
+}
 export default async function ConnectedEvaluationLayout({
   params,
   children,
@@ -66,7 +72,16 @@ export default async function ConnectedEvaluationLayout({
                   />
                 ),
               },
-              { name: <Text.H5M>{evaluation.name}</Text.H5M> },
+              {
+                name: (
+                  <div className='flex flex-row items-center gap-x-4'>
+                    <Text.H4M>{evaluation.name}</Text.H4M>
+                    <Text.H4M color='foregroundMuted'>
+                      {TYPE_TEXT[evaluation.configuration.type]}
+                    </Text.H4M>
+                  </div>
+                ),
+              },
             ]}
           />
         }
@@ -86,8 +101,6 @@ export default async function ConnectedEvaluationLayout({
           commit={commit}
           evaluation={evaluation}
           documentUuid={params.documentUuid}
-          // TODO: Remove decouple from evaluationResults
-          evaluationResults={evaluationResults}
         />
       </Suspense>
       <EvaluationResults

diff --git a/apps/web/src/components/BreadcrumbLink/index.tsx b/apps/web/src/components/BreadcrumbLink/index.tsx
@@ -13,7 +13,7 @@ export default function BreadcrumbLink({
   return (
     <Link href={href} className='flex flex-row items-center gap-2'>
       {showBackIcon && <Icon name='chevronLeft' color='foregroundMuted' />}
-      <Text.H5 color='foregroundMuted'>{name}</Text.H5>
+      <Text.H4M color='foregroundMuted'>{name}</Text.H4M>
     </Link>
   )
 }