Evaluation dashboard

latitude-dev · Sep 10, 2024 · d4bfb94 · d4bfb94
1 parent 9cd6a0b
commit d4bfb94
Show file tree

Hide file tree

Showing 32 changed files with 1,070 additions and 191 deletions.
diff --git a/apps/web/src/actions/connectedEvaluations/fetchConnectedDocuments.ts b/apps/web/src/actions/connectedEvaluations/fetchConnectedDocuments.ts
@@ -0,0 +1,25 @@
+'use server'
+
+import { ConnectedEvaluationsRepository } from '@latitude-data/core/repositories'
+import { z } from 'zod'
+
+import { authProcedure } from '../procedures'
+
+export const fetchConnectedDocumentsAction = authProcedure
+  .createServerAction()
+  .input(
+    z.object({
+      evaluationId: z.number(),
+    }),
+  )
+  .handler(async ({ input, ctx }) => {
+    const connectedEvaluationsScope = new ConnectedEvaluationsRepository(
+      ctx.workspace.id,
+    )
+    const connectedDocuments =
+      await connectedEvaluationsScope.getConnectedDocumentsWithMetadata(
+        input.evaluationId,
+      )
+
+    return connectedDocuments.unwrap()
+  })
diff --git a/apps/web/src/actions/evaluations/connect.test.ts b/apps/web/src/actions/evaluations/connect.test.ts
@@ -1,7 +1,4 @@
-import { randomUUID } from 'crypto'
-
 import {
-  Commit,
   DocumentVersion,
   Project,
   ProviderApiKey,
@@ -30,7 +27,6 @@ describe('connectEvaluationsAction', () => {
       const [_, error] = await connectEvaluationsAction({
         projectId: 1,
         documentUuid: 'fake-document-uuid',
-        commitUuid: 'fake-commit-uuid',
         templateIds: [1],
         evaluationUuids: ['fake-evaluation-uuid'],
       })
@@ -43,7 +39,6 @@ describe('connectEvaluationsAction', () => {
     let workspace: Workspace,
       user: User,
       document: DocumentVersion,
-      commit: Commit,
       provider: ProviderApiKey,
       project: Project
 
@@ -54,7 +49,6 @@ describe('connectEvaluationsAction', () => {
       workspace = setup.workspace
       user = setup.user
       document = setup.documents[0]!
-      commit = setup.commit
       project = setup.project
 
       provider = await factories.createProviderApiKey({
@@ -71,9 +65,10 @@ describe('connectEvaluationsAction', () => {
     })
 
     it('connects evaluations and templates to a document', async () => {
-      const evaluation = await factories.createEvaluation({
-        provider,
+      const evaluation = await factories.createLlmAsJudgeEvaluation({
+        workspace,
         name: 'Test Evaluation',
+        prompt: factories.helpers.createPrompt({ provider }),
       })
 
       const template = await factories.createEvaluationTemplate({
@@ -85,7 +80,6 @@ describe('connectEvaluationsAction', () => {
       const [result, error] = await connectEvaluationsAction({
         projectId: project.id,
         documentUuid: document.documentUuid,
-        commitUuid: commit.uuid,
         templateIds: [template.id],
         evaluationUuids: [evaluation.uuid],
       })
@@ -110,7 +104,6 @@ describe('connectEvaluationsAction', () => {
       const [result, error] = await connectEvaluationsAction({
         projectId: project.id,
         documentUuid: document.documentUuid,
-        commitUuid: commit.uuid,
         templateIds: [],
         evaluationUuids: [],
       })
@@ -123,19 +116,6 @@ describe('connectEvaluationsAction', () => {
       const [_, error] = await connectEvaluationsAction({
         projectId: project.id,
         documentUuid: 'non-existent-uuid',
-        commitUuid: randomUUID(),
-        templateIds: [],
-        evaluationUuids: [],
-      })
-
-      expect(error!.name).toEqual('NotFoundError')
-    })
-
-    it('fails when the commit does not exist', async () => {
-      const [_, error] = await connectEvaluationsAction({
-        projectId: project.id,
-        documentUuid: document.documentUuid,
-        commitUuid: randomUUID(),
         templateIds: [],
         evaluationUuids: [],
       })

diff --git a/apps/web/src/actions/evaluations/connect.ts b/apps/web/src/actions/evaluations/connect.ts
@@ -1,10 +1,5 @@
 'use server'
 
-import { filterEvaluationTemplatesById } from '@latitude-data/core/data-access'
-import {
-  DocumentVersionsRepository,
-  EvaluationsRepository,
-} from '@latitude-data/core/repositories'
 import { connectEvaluations } from '@latitude-data/core/services/evaluations/connect'
 import { z } from 'zod'
 
@@ -15,33 +10,16 @@ export const connectEvaluationsAction = withProject
   .input(
     z.object({
       documentUuid: z.string(),
-      commitUuid: z.string(),
       templateIds: z.array(z.number()),
       evaluationUuids: z.array(z.string()),
     }),
   )
   .handler(async ({ ctx, input }) => {
-    const selectedTemplates = await filterEvaluationTemplatesById(
-      input.templateIds,
-    ).then((r) => r.unwrap())
-    const scope = new EvaluationsRepository(ctx.workspace.id)
-    const selectedEvaluations = await scope
-      .filterByUuids(input.evaluationUuids)
-      .then((r) => r.unwrap())
-
-    const documentsScope = new DocumentVersionsRepository(ctx.workspace.id)
-    const document = await documentsScope
-      .getDocumentAtCommit({
-        projectId: ctx.project.id,
-        commitUuid: input.commitUuid,
-        documentUuid: input.documentUuid,
-      })
-      .then((r) => r.unwrap())
-
     const connectedEvaluations = await connectEvaluations({
-      document,
-      templates: selectedTemplates,
-      evaluations: selectedEvaluations,
+      workspace: ctx.workspace,
+      documentUuid: input.documentUuid,
+      evaluationUuids: input.evaluationUuids,
+      templateIds: input.templateIds,
     }).then((r) => r.unwrap())
 
     return connectedEvaluations

diff --git a/apps/web/src/actions/evaluations/destroy.test.ts b/apps/web/src/actions/evaluations/destroy.test.ts
@@ -32,7 +32,10 @@ describe('destroyEvaluationAction', () => {
         name: 'Test Provider',
         user: userData,
       })
-      const evaluation = await factories.createEvaluation({ provider })
+      const evaluation = await factories.createLlmAsJudgeEvaluation({
+        workspace,
+        prompt: factories.helpers.createPrompt({ provider }),
+      })
       evaluationId = evaluation.id
     })
 
@@ -63,7 +66,10 @@ describe('destroyEvaluationAction', () => {
         name: 'Test Provider',
         user,
       })
-      evaluation = await factories.createEvaluation({ provider })
+      evaluation = await factories.createLlmAsJudgeEvaluation({
+        workspace,
+        prompt: factories.helpers.createPrompt({ provider }),
+      })
 
       mocks.getSession.mockReturnValue({
         user: userData,

diff --git a/apps/web/src/app/(private)/_data-access/index.ts b/apps/web/src/app/(private)/_data-access/index.ts
@@ -5,6 +5,7 @@ import { findAllEvaluationTemplates } from '@latitude-data/core/data-access'
 import { NotFoundError } from '@latitude-data/core/lib/errors'
 import {
   CommitsRepository,
+  ConnectedEvaluationsRepository,
   DocumentLogsRepository,
   DocumentVersionsRepository,
   EvaluationsRepository,
@@ -186,3 +187,17 @@ export const getEvaluationsByDocumentUuidCached = cache(
     return result.unwrap()
   },
 )
+
+export const getConnectedDocumentsWithMetadataCached = cache(
+  async (evaluationId: number) => {
+    const { workspace } = await getCurrentUser()
+    const connectedEvaluationsScope = new ConnectedEvaluationsRepository(
+      workspace.id,
+    )
+    const result =
+      await connectedEvaluationsScope.getConnectedDocumentsWithMetadata(
+        evaluationId,
+      )
+    return result.unwrap()
+  },
+)
diff --git a/.../(private)/evaluations/(evaluation)/[evaluationUuid]/_components/EvaluationTabs/index.tsx b/.../(private)/evaluations/(evaluation)/[evaluationUuid]/_components/EvaluationTabs/index.tsx
@@ -1,20 +1,23 @@
 'use client'
 
+import { Evaluation } from '@latitude-data/core/browser'
 import { TabSelector } from '@latitude-data/web-ui'
 import { useNavigate } from '$/hooks/useNavigate'
 import { EvaluationRoutes, ROUTES } from '$/services/routes'
 import { useSelectedLayoutSegment } from 'next/navigation'
 
 export function EvaluationTabSelector({
-  evaluationUuid,
+  evaluation,
 }: {
-  evaluationUuid: string
+  evaluation: Evaluation
 }) {
   const router = useNavigate()
   const selectedSegment = useSelectedLayoutSegment() as EvaluationRoutes | null
 
   const pathTo = (evaluationRoute: EvaluationRoutes) => {
-    const evaluationDetail = ROUTES.evaluations.detail({ uuid: evaluationUuid })
+    const evaluationDetail = ROUTES.evaluations.detail({
+      uuid: evaluation.uuid,
+    })
     const detail = evaluationDetail[evaluationRoute] ?? evaluationDetail
     return detail.root
   }
@@ -23,7 +26,7 @@ export function EvaluationTabSelector({
     <div className='flex flex-row p-4 pb-0'>
       <TabSelector
         options={[
-          { label: 'History', value: EvaluationRoutes.dashboard },
+          { label: 'Dashboard', value: EvaluationRoutes.dashboard },
           { label: 'Editor', value: EvaluationRoutes.editor },
         ]}
         selected={selectedSegment ?? EvaluationRoutes.dashboard}

diff --git a/...(private)/evaluations/(evaluation)/[evaluationUuid]/_components/EvaluationTitle/index.tsx b/...(private)/evaluations/(evaluation)/[evaluationUuid]/_components/EvaluationTitle/index.tsx
@@ -1,22 +1,7 @@
-'use client'
-
-import { useMemo } from 'react'
-
+import { Evaluation } from '@latitude-data/core/browser'
 import { Text } from '@latitude-data/web-ui'
-import useEvaluations from '$/stores/evaluations'
-
-export function EvaluationTitle({
-  evaluationUuid,
-}: {
-  evaluationUuid: string
-}) {
-  const { data: evaluations } = useEvaluations()
-  const evaluation = useMemo(() => {
-    return evaluations?.find((evaluation) => evaluation.uuid === evaluationUuid)
-  }, [evaluations, evaluationUuid])
-
-  if (!evaluation) return null
 
+export function EvaluationTitle({ evaluation }: { evaluation: Evaluation }) {
   return (
     <div className='flex flex-row items-center justify-between p-4 pb-0'>
       <Text.H4B>{evaluation.name}</Text.H4B>