Unprotect usesocket #1268
Draft
Unprotect usesocket #1268
+17
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankMittelbach
requested changes
Mar 20, 2024
Comment on lines
+606
to
+607
| % was declared! The command is not defined as a protected command so | ||
| % that it works for example also at the end of a tabular. |
There was a problem hiding this comment.
The statement about protected should move to the previous paragraph and perhaps also say that it then depends on the content of the socket if it works.
Comment on lines
+924
to
+926
| % \@@_debug_term:n | ||
| % { Socket~ '#1'~ containing~ plug~ | ||
| % '\str_use:c { l_@@_#1_plug_str }'~ used. } |
There was a problem hiding this comment.
we should probably say why debugging can't be used. In fact we might want to consider supporting a special
\UseAlignSocket as I did had one time --- something to ponder (and perhaps make a remark here).
|
Can you rebase onto current dev? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the unprotected version of \socket_use:nw from latex-lab to ltsockets.
Edit Needs some more thoughts: the plugs must be unprotected too, and the debug message must be removed.
Internal housekeeping
Status of pull request
X Ready to merge
Checklist of required changes before merge will be approved
\changesentries in source includedchanges.txtupdatedltnewsX.tex(and/orlatexchanges.tex) updated (imho unneeded)