Skip to content

Commit

Permalink
43: Patch guest features default value
Browse files Browse the repository at this point in the history
Due to a [discussion happening in the linux kernel mailing list](https://lore.kernel.org/kvm/[email protected]/T/), it is expected that the default guest features should no longer include `DEBUG_SWAP` by default. This changes the default value back to `0x1` to comply with those changes.

Resolves virtee#43

Signed-off-by: Larry Dewey <[email protected]>
  • Loading branch information
larrydewey committed Mar 18, 2024
1 parent e7b20fa commit f89f064
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ options:
--append CMDLINE Kernel command line to calculate hash from (use with --kernel)
--guest-features VALUE
Hex representation of the guest kernel features expected to be included
(defaults to 0x21); see README.md for possible values
(defaults to 0x1); see README.md for possible values
--output-format {hex,base64}
Measurement output format
--snp-ovmf-hash HASH Precalculated hash of the OVMF binary (hex string)
Expand Down
4 changes: 2 additions & 2 deletions sevsnpmeasure/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,9 @@ def main() -> int:
parser.add_argument('--append', metavar='CMDLINE',
help='Kernel command line to calculate hash from (use with --kernel)')
parser.add_argument('--guest-features', metavar='VALUE', type=lambda x: int(x, 0),
default=0x21,
default=0x1,
help="Hex representation of the guest kernel features expected to be included "
"(defaults to 0x21); see README.md for possible values"),
"(defaults to 0x1); see README.md for possible values"),
parser.add_argument('--output-format', choices=['hex', 'base64'], help='Measurement output format', default='hex')
parser.add_argument('--snp-ovmf-hash', metavar='HASH', help='Precalculated hash of the OVMF binary (hex string)')
parser.add_argument('--dump-vmsa', action='store_true',
Expand Down

0 comments on commit f89f064

Please sign in to comment.