Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new default avatar using a greyscale Laravel logo #759

Merged
merged 8 commits into from
Jan 8, 2022

Conversation

joelbutcher
Copy link
Contributor

@joelbutcher joelbutcher commented Nov 19, 2021

Resolves #688

Screenshot 2021-11-19 at 15 11 27

Screenshot 2021-11-19 at 14 44 58

Screenshot 2021-11-19 at 14 45 01

Screenshot 2021-11-19 at 14 47 14

Screenshot 2021-11-19 at 15 11 00

Screenshot 2021-11-19 at 15 11 04

@driesvints
Copy link
Member

Can you post some screenshots of the profile page, thread detail page, forum overview page and homepage with the user cloud so we can see how this looks?

@joelbutcher
Copy link
Contributor Author

@driesvints Yup, I took screenshots, but in my haste forgot to upload them with the PR 🤦

@driesvints driesvints self-assigned this Nov 19, 2021
@driesvints
Copy link
Member

@joelbutcher hmm I'm now thinking that maybe the Laravel.io logo might be a bit better. Can you replace that with https://github.com/laravelio/laravel.io/blob/main/public/images/laravelio-icon.svg ? It can even be a slightly more lighter gray so it blends in with the background a bit more. The profile image setting one can be a bit smaller like the one on the profile page.

@joelbutcher
Copy link
Contributor Author

@driesvints like this?

Screenshot 2021-11-22 at 09 34 28

Screenshot 2021-11-22 at 09 41 28

Screenshot 2021-11-22 at 09 41 24

Screenshot 2021-11-22 at 09 34 25

@joelbutcher
Copy link
Contributor Author

@driesvints how do these screenshots look to you?

@driesvints
Copy link
Member

@joelbutcher I haven't found time yet to look at this yet, sorry. Might be a while.

@driesvints
Copy link
Member

@joelbutcher heya, I'm so sorry I didn't get to this yet. Could you maybe rebase this PR with master and make sure it's adapted for Tailwind v3? I'll try to work on it in the next couple of weeks. Thanks!

@joelbutcher
Copy link
Contributor Author

@driesvints done 👍

@driesvints driesvints merged commit 9eb234c into laravelio:main Jan 8, 2022
@driesvints
Copy link
Member

Thanks for this @joelbutcher! Sorry it took this long before I got to this.

@joelbutcher
Copy link
Contributor Author

@driesvints No problems - I just assumed you're busy with the next Laravel release this month!

@joelbutcher joelbutcher deleted the feature/new-default-avatar branch April 6, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Replace default GitHub avatar
2 participants