Feature: add phpredis zstd compression support #104
+24
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imes and update sizes.md
…ort' into feat/redis_zstd_compression_support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
First off, love your work. We (iseekplant.com.au) use Vapor to manage around 30 applications and 4 Redis clusters of varying sizes. We run one of our Redis clusters at 100% memory utilisation relying on LFU evictions to keep the cache fresh, and being able to transparently compress the cache values would allow us to utilise that cluster even more. So, recently I tried to enable cache compression following the Laravel docs here but found that compression support wasn't compiled into phpredis extension in the vapor runtime.
This PR adds only Zstandard compression in order to keep the PR small but also to minimise the layer size; on average it has added ~900kb to each version of the exported zip. I've also tested the exported layer in our production environment to ensure it works as expected.
We hope you'll consider merging and thanks for your hard work!
Cheers,
~Ben Plunkett