fix: merge Algolia4 options into query parameters #891
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
In Algolia v3, search options were included directly in the query parameters. However, in Algolia v4, options passed as the third parameter to the searchSingleIndex method are interpreted as request options, affecting headers and query strings, which can lead to unintended behavior—specifically, options like hitsPerPage become ineffective.
Changes:
Used array_merge to combine $options with $queryParams, ensuring all search options are included in the query parameters as expected by Algolia v4.
Stopped passing $options as the third argument to searchSingleIndex to prevent them from being misinterpreted as request options.
Impact:
Ensures that options like hitsPerPage now function correctly.
Aligns our implementation with Algolia v4's expected input handling.