Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merge Algolia4 options into query parameters #891

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

MingJen
Copy link
Contributor

@MingJen MingJen commented Dec 3, 2024

Background

In Algolia v3, search options were included directly in the query parameters. However, in Algolia v4, options passed as the third parameter to the searchSingleIndex method are interpreted as request options, affecting headers and query strings, which can lead to unintended behavior—specifically, options like hitsPerPage become ineffective.

Changes:

  • Merge $options into $queryParams
    Used array_merge to combine $options with $queryParams, ensuring all search options are included in the query parameters as expected by Algolia v4.
  • Remove Third Parameter
    Stopped passing $options as the third argument to searchSingleIndex to prevent them from being misinterpreted as request options.

Impact:

  • Correct Application of Search Options
    Ensures that options like hitsPerPage now function correctly.
  • Consistency with Algolia v4 Behavior
    Aligns our implementation with Algolia v4's expected input handling.

@MingJen MingJen force-pushed the fix-algolia-option branch from eeb30af to c8774cb Compare December 3, 2024 05:17
@taylorotwell taylorotwell merged commit dabe61f into laravel:10.x Dec 3, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants