Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort models after fetching when orders conditions are applied to search #849

Closed

Conversation

lubatti
Copy link

@lubatti lubatti commented Jul 17, 2024

I've found that after applying a custom order logic to the search engine and retrieving a subset of ids, these ids can be re-sorted during the fetching of the models.

@crynobone
Copy link
Member

This is only supported by MySQL and SQLite and will cause syntax error in Postgres and MSSQL

@lubatti lubatti changed the title Use ORDER BY FIELD when fetching models from ids Sort models after fetching when orders conditions are applied to search Jul 17, 2024
@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants