[10.x] Get the key name through getScoutKeyName() on the Database engine #843
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why the database engine is the only still using
getKeyName()
, but it should be usinggetScoutKeyName()
as all the others. I just found this while trying to set a custom ID for my searches other than the one I'm using for normal usage of the searchable model.While trying to join a table:
Scout was raising a
Column 'id' in order clause is ambiguous
caused by an unqualifiedorder by id
that was not possible to customize as the only way would be by overloadinggetKeyName()
and that would break how things work for my Post model out of the search context.