Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events #226

Closed
wants to merge 6 commits into from
Closed

Events #226

wants to merge 6 commits into from

Conversation

d0m4te
Copy link

@d0m4te d0m4te commented Jul 12, 2024

No description provided.

Copy link

Thanks for submitting a PR!

In order to review and merge PRs most efficiently, we require that all PRs grant maintainer edit access before we review them. For information on how to do this, see the relevant GitHub documentation. Additionally, GitHub doesn't allow maintainer permissions from organization accounts. Please resubmit this PR from a personal GitHub account with maintainer permissions enabled.

@github-actions github-actions bot closed this Jul 12, 2024
@LAGGOUNE-Walid
Copy link

@d0m4te , @michaelnabil230
I was thinking to build the same logic (events for connection and disconnection) , but thinking for a sec , i realized there is serious issue and disadvantage (if connections number is big) with this events: ConnectionClosed also NewConnection .
Think of this scenario :
There is thousands or even millions of connections connected to reverb server, there are cases when all connections start reconnecting at the same time. Even if ConnectionClosed/NewConnection events were queued, there could be situations when the listeners for this events handle the disconnect hook (event) after user already reconnected ! and then mark this user as disconnected but in realty the user is reconnected (connected).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants