[1.x] Sends content length to address OpenSSL issue #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
reviewed
Apr 23, 2024
|
|
||
| use Symfony\Component\HttpFoundation\JsonResponse; | ||
|
|
||
| class Response extends JsonResponse |
There was a problem hiding this comment.
Do we want to name this specifically ReverbResponse so it's more clear in error logs when this response is logged?
There was a problem hiding this comment.
Possibly though that doesn't match the naming of anything else in that directory.
I'm waiting on a test to verify this actually resolves the issue anyway so will wait until then before making any further changes.
|
It's works for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using newer versions of OpenSSL, we are running into the following error when trying to broadcast a message:
It would appear to relate to OpenSSL changing its defaults in handling "unexpected" EOF
To resolve this, I have implemeted a new
Laravel\Reverb\Servers\Reverb\Http\Responseclass which inherits from Symfony'sJsonResponsewhich automatically sets theContent-Lengthheader and informs OpenSSL when to close.This PR resolves #163