Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Fixes SSL connection issues in Chrome / Arc #159

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

joedixon
Copy link
Collaborator

When used with secure sites on Valet or Herd, Reverb will automatically discover the certificate and use it to enable secure WebSocket connections.

This works nicely, but there are issues in Chrome.

If you use Echo to connect over wss, Chrome will reject the connection without any useful reason why.

What's even more strange is if you navigate to https://site.test:8080 in the browser, Reverb will load the page with no SSL error.

After doing so, attempting to connect via Echo again (wss://site.test:8080), results in a successful connection 🤷

I was able to go deep into Chrome and review the logs which exposed an error: ERR_SSL_CLIENT_AUTH_CERT_NEEDED

This indicates an issue in the SSL handshake between client and server. The server doesn't trust the certificate being used by the client - strange because it works fine over https.

By disabling peer verification, the handshake completes successfully.

I still believe this to be an issue with the browser, but this does resolve the issue and I don't really see an issue with disabling verify_peer in local development.

@taylorotwell taylorotwell merged commit 77fb819 into main Apr 18, 2024
11 checks passed
@taylorotwell taylorotwell deleted the fix/ssl-connection branch April 18, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants