Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Handles Telescope ingest #151

Merged
merged 4 commits into from
Apr 16, 2024
Merged

[1.x] Handles Telescope ingest #151

merged 4 commits into from
Apr 16, 2024

Conversation

joedixon
Copy link
Collaborator

This PR resolves #148

Telescope works by stroing events after a response has been sent or a job processed. With Reverb, neither of these things happen so Telescope entries accumulate causing in memory consumption.

This PR attempts to address that by periodically storing and flushing the buffer of entries in a similar approach to Pulse.

@joedixon joedixon marked this pull request as ready for review April 16, 2024 07:11
@taylorotwell taylorotwell merged commit bf6b6f8 into main Apr 16, 2024
9 checks passed
@taylorotwell taylorotwell deleted the fix/telescope branch April 16, 2024 14:02
@maartengithub
Copy link

maartengithub commented Apr 18, 2024

If you have telescope installed but, as documented, in production you don't load the TelescopeServiceProvider, then reverb fails on this line in script StartServer.php:

\Laravel\Telescope\Telescope::store($this->laravel->make(\Laravel\Telescope\Contracts\EntriesRepository::class));

because EntriesRepository is not bound. Am I missing something here?

@joedixon
Copy link
Collaborator Author

@maartengithub this is a great catch, thank you. Updated here: #164

@maartengithub
Copy link

maartengithub commented Apr 20, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak with telescope
4 participants