Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Allow non-Pusher and ClientEvent messages #133

Closed
wants to merge 2 commits into from

Conversation

rihardsgrislis
Copy link

Hey,

Love using Reverb so far! 🚀

I would like to use the websocket server to receive non-Laravel messages from other clients as well and handle the messages in my app. I have some IoT devices that allow for outbound websocket.
The MessageReceived event is already implemented and I can just listen for it in the app. However it doesn't get executed because if the message doesn't contain the "event" key the server fails handling the message (Undefined array key "event") and sends 'event' => 'pusher:error' event to the client with message "Invalid message format".

We just need to check for the "event" key before using the Pusher or ClientEvent handler.

@rihardsgrislis rihardsgrislis changed the title [1.x] Allow non-pusher/client messages [1.x] Allow non-Pusher/ClientEvent messages Apr 6, 2024
@rihardsgrislis rihardsgrislis changed the title [1.x] Allow non-Pusher/ClientEvent messages [1.x] Allow non Pusher/ClientEvent messages Apr 6, 2024
@rihardsgrislis rihardsgrislis changed the title [1.x] Allow non Pusher/ClientEvent messages [1.x] Allow non-Pusher and ClientEvent messages Apr 6, 2024
@rihardsgrislis rihardsgrislis deleted the patch-2 branch April 6, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant