revert limit

laravel · Nov 27, 2023 · c7ef819 · c7ef819
1 parent 2b6d622
commit c7ef819
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 16 deletions.
diff --git a/config/reverb.php b/config/reverb.php
@@ -38,7 +38,6 @@
                 'enabled' => env('REVERB_SCALING_ENABLED', false),
                 'channel' => env('REVERB_SCALING_CHANNEL', 'reverb'),
             ],
-            'connection_limit' => env('REVERB_CONNECTION_LIMIT', null),
         ],
 
         'api_gateway' => [

diff --git a/src/Servers/Reverb/Console/Commands/StartServer.php b/src/Servers/Reverb/Console/Commands/StartServer.php
@@ -45,7 +45,7 @@ public function handle(): void
         $this->subscribeToRedis($loop);
         $this->scheduleCleanup($loop);
 
-        $server = ServerFactory::make($host, $port, $config['connection_limit'], $loop);
+        $server = ServerFactory::make($host, $port, $loop);
 
         $this->components->info("Starting server on {$host}:{$port}");
 

diff --git a/src/Servers/Reverb/Factory.php b/src/Servers/Reverb/Factory.php
@@ -26,12 +26,10 @@ class Factory
     /**
      * Create a new WebSocket server instance.
      */
-    public static function make(string $host = '0.0.0.0', string $port = '8080', int $connectionLimit = null, LoopInterface $loop = null)
+    public static function make(string $host = '0.0.0.0', string $port = '8080', LoopInterface $loop = null)
     {
         $loop = $loop ?: Loop::get();
-        $socket = new LimitingServer(
-            new SocketServer("{$host}:{$port}", [], $loop), $connectionLimit
-        );
+        $socket = new SocketServer("{$host}:{$port}", [], $loop);
 
         $router = new Router(new UrlMatcher(static::routes(), new RequestContext));
 

diff --git a/tests/Feature/Reverb/ServerTest.php b/tests/Feature/Reverb/ServerTest.php
@@ -314,15 +314,6 @@
     $this->connect();
 });
 
-it('cconnections can be limited', function () {
-    $this->app['config']->set('reverb.servers.reverb.connection_limit', 1);
-    $this->stopServer();
-    $this->startServer();
-    $this->connect();
-
-    $this->connect();
-})->throws('Connection closed before handshake');
-
 it('limits the size of messages', function () {
     $connection = $this->connect(key: 'pusher-key-3', headers: ['Origin' => 'http://laravel.com']);
     $message = $this->send(['This message is waaaaaay longer than the 1 byte limit'], $connection);

diff --git a/tests/ReverbTestCase.php b/tests/ReverbTestCase.php
@@ -99,7 +99,7 @@ public function usingRedis()
     public function startServer($host = '0.0.0.0', $port = '8080')
     {
         $this->resetFiber();
-        $this->server = Factory::make($host, $port, config('reverb.servers.reverb.connection_limit'), $this->loop);
+        $this->server = Factory::make($host, $port, $this->loop);
     }
 
     /**