Enhanced installation adding configurable database conncetion prompts #326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Fresh installation of laravel using any database driver rather than sqlite starts with an error of can't connect with database. (more information ar #324)
Description:
This PR is supposed to make laravel installation smoother and more user-friendly by removing unnecessary migration prompt when database connection is not specified for drivers rather than mysql.
**Here's a video comparing current installer and patched installer experience **
0318.mp4
laravel-installer-linux.mp4
Also,
The migration prompt won't appear when database connection is not specified.
Changes Made:
promptForDatabaseConfig
function to specify the database connection.commentDatabaseConfigurationForSqlite
to configureDefaultDatabaseConnectionAny feedback & suggestions will be appreciated. Thank You.