Check for latest version #308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to table this for now. |
|
Sorry @Jubeki, this was my bad. This won't work with situations where the installer is installed using Herd, etc. Thanks for your attempt. |
|
@driesvints I initially had only printed that a new version is available, would this instead be better:
|
|
It would be the solution doesn't apply for Herd. Let's just table this one for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #306
This prompts the user to update the Laravel Installer before continuing.
How it looks like when the update will be installed (composer messages are wrong because the Laravel Installer Version was changed manually, and therefor Composer does not update anything)
How it looks like when you continue:
To test this you can to the following:
composer global updatesrc/NewCommand.phpin this PR~/.composer/vendor/laravel/installer/src/NewCommand.php~/.composer/vendor/laravel/installer/bin/laravelinto5.3.0laravel new test --no-interactionTo test if the check is not run, you can simply change the version back to
5.4.0.Considerations
There is also the question how you want to handle downtime with Github. Probably then assuming you are on the latest version?