Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mariadb installation option #292

Merged
merged 6 commits into from
Nov 28, 2023

Conversation

Jubeki
Copy link
Contributor

@Jubeki Jubeki commented Nov 9, 2023

Laravel 11 will support a new Maria DB Configuration in config/database.php (due to slimming the skeleton this will be moved to the framework).

A developer should be able to select the option mariadb during installation. Which will fallback to mysql in Laravel 10 and will use the mariadb configuration in Laravel 11.

Note: This PR will be draft until the slimmed skeleton is merged. Because the Slimmed skeleton branch is not working, I can not verify if everything works as intended.

Works on the master branch and the 10.x branch

Tested as follows:
Replace the file in ~/.composer/vendor/laravel/installer/src/NewCommand.php
Run laravel new l11 --dev and select database mariadb => .env should contain mariadb
Run laravel new l10 and select database mariadb => .env should contain mysql

src/NewCommand.php Outdated Show resolved Hide resolved
@Jubeki Jubeki marked this pull request as ready for review November 28, 2023 20:34
@taylorotwell taylorotwell merged commit 18101b3 into laravel:master Nov 28, 2023
7 checks passed
@Jubeki Jubeki deleted the add-mariadb-installation-option branch November 29, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants