-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.x] Validate UUID's version optionally #53341
Merged
taylorotwell
merged 10 commits into
laravel:master
from
shaedrich:validate-uuid-version
Oct 31, 2024
Merged
[12.x] Validate UUID's version optionally #53341
taylorotwell
merged 10 commits into
laravel:master
from
shaedrich:validate-uuid-version
Oct 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you add a test and mark as ready for review? |
Suggested-by: Vano Devium <[email protected]> cc: Vano Devium <[email protected]> thanks-to: Vano Devium <[email protected]> original-patch-by: Vano Devium <[email protected]> based-on-a-patch-by: Vano Devium <[email protected]> based-on-patch-by: Vano Devium <[email protected]> credit-to: Vano Devium <[email protected]> inspired-by-patch-by: Vano Devium <[email protected]> initial-work-by: Vano Devium <[email protected]> inspired-by: laravel#21672
Suggested-by: Vano Devium <[email protected]> cc: Vano Devium <[email protected]> thanks-to: Vano Devium <[email protected]> original-patch-by: Vano Devium <[email protected]> based-on-a-patch-by: Vano Devium <[email protected]> based-on-patch-by: Vano Devium <[email protected]> credit-to: Vano Devium <[email protected]> inspired-by-patch-by: Vano Devium <[email protected]> initial-work-by: Vano Devium <[email protected]> inspired-by: laravel#21672
Tests are added as asked |
shaedrich
added a commit
to shaedrich/framework
that referenced
this pull request
Oct 31, 2024
– Remove unused imports – Spacing improves: laravel#53341
taylorotwell
added a commit
that referenced
this pull request
Nov 1, 2024
* feat: ✨ Add support for UUID v2 and max UUID validation * test: ✅ Add cases for every supported UUID version to data provider of UUID validation tests * style: 🎨 Fix StyleCI errors – Remove unused imports – Spacing improves: #53341 * Add missing import * style: 🎨 Remove indent from blank line * Add ramsey/uuid to composer suggestions to be able to use it for UUID version constraint validation * Update Str.php * Update Str.php --------- Co-authored-by: Taylor Otwell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revive #21672 by @vanodevium
That allows to do something like this: