Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] feat: restore type-narrowing bahavior for throw_* helpers #53164

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

crishoj
Copy link
Contributor

@crishoj crishoj commented Oct 15, 2024

Follow-up to #53154 from yesterday, based on input from @calebdw.

Restore the type-narrowing behavior of throw_if / throw_unless when passed a strictly boolean condition:

/** @var float|int $foo */
throw_if(is_float($foo));
assertType('int', $foo);

@taylorotwell taylorotwell merged commit ddfbbf0 into laravel:11.x Oct 15, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants