Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.x] Add generic return type to Container::instance() #53161

Merged
merged 1 commit into from
Oct 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Illuminate/Container/Container.php
Original file line number Diff line number Diff line change
Expand Up @@ -488,9 +488,11 @@ public function extend($abstract, Closure $closure)
/**
* Register an existing instance as shared in the container.
*
* @template TInstance
*
* @param string $abstract
* @param mixed $instance
* @return mixed
* @param TInstance $instance
* @return TInstance
*/
public function instance($abstract, $instance)
{
Expand Down
6 changes: 4 additions & 2 deletions src/Illuminate/Contracts/Container/Container.php
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,11 @@ public function extend($abstract, Closure $closure);
/**
* Register an existing instance as shared in the container.
*
* @template TInstance
*
* @param string $abstract
* @param mixed $instance
* @return mixed
* @param TInstance $instance
* @return TInstance
*/
public function instance($abstract, $instance);

Expand Down
10 changes: 10 additions & 0 deletions types/Container/Container.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php

use Illuminate\Http\Request;

use function PHPStan\Testing\assertType;

/**
* @var \Illuminate\Container\Container $container
*/
assertType('Illuminate\Http\Request', $container->instance('request', Request::capture()));
10 changes: 10 additions & 0 deletions types/Contracts/Container/Container.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php

use Illuminate\Http\Request;

use function PHPStan\Testing\assertType;

/**
* @var \Illuminate\Contracts\Container\Container $container
*/
assertType('Illuminate\Http\Request', $container->instance('request', Request::capture()));