[11.x] Add containsAny
method to Collection
#52373
Closed
+57
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR contains
This PR adds the
containsAny
method to Collections which returns true if any of the supplied items are contained within the collection.Some tests have also been added.
Why this PR should be merged
There currently exists a gap in the available methods for collections. Users can check if multiple items all exist in a collection with
contains
, however there is no similarcontainsAny
method to provide OR functionality. The current workaround for users is to useintersect
which I believe is not sufficiently elegant and expressive for laravel.For example:
Readers of this code must remind themselves of the definition of an intersection, and consider the meaning of both
intersect
andisNotEmpty
together when understanding the functionality here. Following this PR, this code becomes more terse and easily understandable, and reads like an english sentence.Furthermore, the method
hasAny
already exists for collections as a similar OR-analogue forhas
, which may lead users to expect there to exist acontainsAny
method as a OR-analogue forcontains
, which this PR provides.