Skip to content

Commit

Permalink
[12.x] Test Improvements (#53150)
Browse files Browse the repository at this point in the history
* Add missing docblock
* Fixes new tests to be compatible with 12.x code

Signed-off-by: Mior Muhammad Zaki <[email protected]>
  • Loading branch information
crynobone authored Oct 14, 2024
1 parent 7cea976 commit 7299a1d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions src/Illuminate/Database/Schema/Blueprint.php
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ class Blueprint
/**
* Create a new schema blueprint.
*
* @param \Illuminate\Database\Connection $connection
* @param string $table
* @param \Closure|null $callback
* @param string $prefix
Expand Down
2 changes: 1 addition & 1 deletion tests/Database/DatabaseMySqlSchemaGrammarTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -1326,7 +1326,7 @@ public function testAddingComment()

public function testAddingVector()
{
$blueprint = new Blueprint('embeddings');
$blueprint = new Blueprint($this->getConnection(), 'embeddings');
$blueprint->vector('embedding', 384);
$statements = $blueprint->toSql($this->getConnection(), $this->getGrammar());

Expand Down
2 changes: 1 addition & 1 deletion tests/Database/DatabasePostgresSchemaGrammarTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public function testBasicCreateTable()

public function testAddingVector()
{
$blueprint = new Blueprint('embeddings');
$blueprint = new Blueprint($this->getConnection(), 'embeddings');
$blueprint->vector('embedding', 384);
$statements = $blueprint->toSql($this->getConnection(), $this->getGrammar());

Expand Down

0 comments on commit 7299a1d

Please sign in to comment.