-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.x] Add option to install ESLint with Prettier #412
Conversation
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
d73beab
to
ae64488
Compare
Thanks! |
This has messed up the CI. cc @crynobone @driesvints |
this introduced a ton of deprecation warnings to any apps that use this option |
@kjjd84 Can you elaborate on what kind of deprecation warnings you got? |
npm warn deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated @humanwhocodes/[email protected]: Use @eslint/config-array instead
npm warn deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated @humanwhocodes/[email protected]: Use @eslint/object-schema instead |
@kjjd84 The warnings are coming from
|
@kjjd84 Vue and Next.js CLIs are also using ESLint 8. I got the same deprecation warnings when I scaffolded Vue and Next apps. It's unavoidable during the transition period. We will upgrade to ESLint 9 as soon as they migrate to ESLint 9. |
@avosalmon I noticed that when using the Laravel installer, the "ESLint with Prettier" option is not listed among the optional features. Will this be added there as well? |
@whoami15 Let me add it to the installer. Thanks for bringing this up! |
@whoami15 It will be available in the next release laravel/installer#361 |
This PR introduces an option to install and configure ESLint with Prettier for the Inertia stacks.
Selecting the
ESLint with Prettier
option will install ESLint and Prettier with some relevant plugins and add config files.lint
node script to package.jsonNote
Most of the changes for the stubs are code style changes by CI (14759fc, 60a5a2a). Following the commit logs would make it easier to review the changes rather than diving into the files changed.