Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #63

Merged
merged 15 commits into from
Mar 20, 2024
Merged

Refactoring #63

merged 15 commits into from
Mar 20, 2024

Conversation

Kovah
Copy link
Collaborator

@Kovah Kovah commented Mar 11, 2024

Contains a kind of major cleanup and refactoring to ensure this package stays up-to-date.

Included changes

  • Length of Pushover API key is checked for the correct length.
  • fire() was replaced by dispatch() in PushoverChannel.
  • $notifiable was missing in the send() method for proper error reporting.
  • ext-exif was added as an optional requirement for image attachments.
  • Compatibility with Laravel 11, including update of tests.
  • Bump the minimum required PHP version to 8.1, as 8.0 is no longer maintained.
  • Refactoring of classes to match 8.1 coding features such as typed properties and params.

@Kovah
Copy link
Collaborator Author

Kovah commented Mar 11, 2024

Hi @atymic, the CI pipelines contain uploads to Scrutinizer that are failing due to missing authentication. Seems like this is no longer available. Is it safe to remove the corresponding action step?

@Kovah
Copy link
Collaborator Author

Kovah commented Mar 19, 2024

Ping @atymic

@atymic
Copy link
Member

atymic commented Mar 20, 2024

Yep just delete it.

@Kovah Kovah merged commit 31ff8c1 into master Mar 20, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants