Skip to content

Commit

Permalink
📝 documentation
Browse files Browse the repository at this point in the history
  • Loading branch information
laquasicinque committed Jul 10, 2021
1 parent 8c97823 commit 2cfae6f
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 68 deletions.
81 changes: 14 additions & 67 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,71 +1,18 @@
![](https://img.shields.io/badge/Foundry-v0.8.6-informational)
<!--- Downloads @ Latest Badge -->
<!--- replace <user>/<repo> with your username/repository -->
<!--- ![Latest Release Download Count](https://img.shields.io/github/downloads/<user>/<repo>/latest/module.zip) -->
# Monaco Macro Editor

<!--- Forge Bazaar Install % Badge -->
<!--- replace <your-module-name> with the `name` in your manifest -->
<!--- ![Forge Installs](https://img.shields.io/badge/dynamic/json?label=Forge%20Installs&query=package.installs&suffix=%25&url=https%3A%2F%2Fforge-vtt.com%2Fapi%2Fbazaar%2Fpackage%2F<your-module-name>&colorB=4aa94a) -->
This module adds the [Monaco Editor](https://github.com/Microsoft/monaco-editor) (the editor used in VS Code, as well as other online editors) as the macro editor in Foundry, allowing users to use a slightly slimmed down version of the editor within foundry itself. It also adds [types](https://github.com/League-of-Foundry-Developers/foundry-vtt-types) provided by the League Of Foundry Developers to allow for a nicer scripting experience from within Foundry itself.

A thing to note about the module, whilst the Monaco Editor is very powerful, it could be a bit too heavy for those who are on a weaker machine, in which case I'd recommend using the [Ace Macro Editor](https://foundryvtt.com/packages/macroeditor) instead.

# How to use this Template to create a versioned Release
## For Library/Module Developers

1. Open your repository's releases page.

![Where to click to open repository releases.](https://user-images.githubusercontent.com/7644614/93409301-9fd25080-f864-11ea-9e0c-bdd09e4418e4.png)

2. Click "Draft a new release"

![Draft a new release button.](https://user-images.githubusercontent.com/7644614/93409364-c1333c80-f864-11ea-89f1-abfcb18a8d9f.png)

3. Fill out the release version as the tag name.

If you want to add details at this stage you can, or you can always come back later and edit them.

![Release Creation Form](https://user-images.githubusercontent.com/7644614/93409543-225b1000-f865-11ea-9a19-f1906a724421.png)

4. Hit submit.

5. Wait a few minutes.

A Github Action will run to populate the `module.json` and `module.zip` with the correct urls that you can then use to distribute this release. You can check on its status in the "Actions" tab.

![Actions Tab](https://user-images.githubusercontent.com/7644614/93409820-c1800780-f865-11ea-8c6b-c3792e35e0c8.png)

6. Grab the module.json url from the release's details page.

![image](https://user-images.githubusercontent.com/7644614/93409960-10c63800-f866-11ea-83f6-270cc5d10b71.png)

This `module.json` will only ever point at this release's `module.zip`, making it useful for sharing a specific version for compatibility purposes.

7. You can use the url `https://github.com/<user>/<repo>/releases/latest/download/module.json` to refer to the manifest.

This is the url you want to use to install the module typically, as it will get updated automatically.

# How to List Your Releases on Package Admin

To request a package listing for your first release, go to the [Package Submission Form](https://foundryvtt.com/packages/submit) (accessible via a link at the bottom of the "[Systems and Modules](https://foundryvtt.com/packages/)" page on the Foundry website).

Fill in the form. "Package Name" must match the name in the module manifest. Package Title will be the display name for the package. Package URL should be your repo URL.
![image](https://user-images.githubusercontent.com/36359784/120664263-b49e5500-c482-11eb-9126-af7006389903.png)


One of the Foundry staff will typically get back to you with an approval or any further questions within a few days, and give you access to the package admin pages.

Once you have access to the [module admin page](https://foundryvtt.com/admin/packages/package/), you can release a new version by going into the page for your module, scrolling to the bottom, and filling in a new Package Version.

When listing a new version, Version should be the version number you set above, and the Manifest URL should be the manifest __for that specific version__ (do not use /latest/ here).
![image](https://user-images.githubusercontent.com/36359784/120664346-c4b63480-c482-11eb-9d8b-731b50d70939.png)

> ### :warning: Important :warning:
>
> It is very important that you use the specific release manifest url, and not the `/latest` url here. For more details about why this is important and how Foundry Installs/Updates packages, read [this wiki article](https://foundryvtt.wiki/en/development/guides/releases-and-history).
Clicking "Save" in the bottom right will save the new version, which means that anyone installing your module from within Foundry will get that version, and a post will be generated in the #release-announcements channel on the official Foundry VTT Discord.


# FoundryVTT Module

Does something, probably

## Changelog
To make it easier to add new typings for other modules and libraries to foundry, a hook provides a function to register types. the register function takes a fake filepath and the typescript file as a string.
```ts
Hooks.on("monaco-editor.ready", (registerTypes) => {
registerTypes("module-name/index.ts", `
declare class Foo {
bar (): string | null
}
`)
})
```
1 change: 0 additions & 1 deletion src/module.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import * as monaco from "monaco-editor";
import { attachMonacoEditor, registerTypes, setupMonaco } from "./editor";
import { furnaceFix } from "./fixes/furnace";
import { registerSettings } from "./settings";
Expand Down

0 comments on commit 2cfae6f

Please sign in to comment.