Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assembly signing. #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JackEker
Copy link

Update nuget binary. Update NLog & log4net dependency versions.

Update nuget binary. Update NLog & log4net dependecy versions.
@lanwin
Copy link
Owner

lanwin commented Sep 12, 2016

Thanks for your pullrequest. Seems legit so far, but I am not sure about the signing.

I stopped using signing long ago since it brought mostly problems. I know other projects like mspec which switched to have a normal unsigned and a mspec-signed nuget package, maybe that would be a good choice here too.

What did you think?

@JackEker
Copy link
Author

Ahh right, if you have problems with signing not to worry. :)

Both the dependencies are strongly named, so there shouldn't be any maintenance issues. Being signed also means that both unsigned and signed assemblies can use the project without an issue.

With regards to releasing a signed nuget package too, well that is a viable option but makes the maintenance and upkeep costs a little higher.

If you don't need this to be signed, not a problem. I have a version of the nuget package that's signed now, off the back of this work. So I can use that going forwards if needs be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants