Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update spack2 v2 to spack2 v3 #83

Merged
merged 4 commits into from
Nov 30, 2023
Merged

update spack2 v2 to spack2 v3 #83

merged 4 commits into from
Nov 30, 2023

Conversation

Yurlungur
Copy link
Collaborator

PR Summary

Update to spack2 v3. This involves updating the spackage, as well as updating the cmake.

PR Checklist

  • Code is formatted. (You can use the format_spiner make target.)
  • Adds a test for any bugs fixed. Adds tests for new features.
  • If preparing for a new release, update the version in cmake.

@dholladay00
Copy link
Collaborator

I know this is scope creep but I'm looking right now at doing this, would you be willing to add a test variant to the spackage and make catch an optional dependency @Yurlungur ?

@Yurlungur
Copy link
Collaborator Author

I know this is scope creep but I'm looking right now at doing this, would you be willing to add a test variant to the spackage and make catch an optional dependency @Yurlungur ?

Will do that's an easy change.

@Yurlungur
Copy link
Collaborator Author

Tests pass and @mauneyc-LANL approved it so I'm clicking the button.

@Yurlungur Yurlungur merged commit 33862f8 into main Nov 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants