Skip to content

Commit

Permalink
improve umt code change paragraph.
Browse files Browse the repository at this point in the history
  • Loading branch information
aaroncblack committed Mar 11, 2024
1 parent e96ef33 commit 8694a5b
Showing 1 changed file with 7 additions and 8 deletions.
15 changes: 7 additions & 8 deletions doc/sphinx/06_umt/umt.rst
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,13 @@ value across the array, as the benchmarks use a simplified single material probl
be collapsed to a scalar, as production problems of interest will have a spread of values in these arrays for multi-material problems.

The provided benchmark problems in UMT only model a subset of the problem types and input that UMT can run. When refactoring or optimizing code in
UMT, vendors should consult with the RFP team before removing any calculations from code, even if the benchmark problems still pass the correctness
check. Removing calculations may not impact the simplified benchmark problems, but all calculations are in the code for a reasion and removing them
may cause other problem configurations to fail.

One example of this is a portion of code in the sweep routines ( source files beginning with 'SweepUCB' ). There is a loop labelled 'TestOppositeFace'
which is designed to provide a higher order of accuracy when running a problem with less opaque materials. The benchmark problems are not impacted by
this code section, as their material is fairly opaque, but this code should not be removed as it will impact many other problems of interest to our
production code when modelling less opaque materials.
UMT, vendors should consult with the RFP team before removing any exercised calculations in code, even if the benchmark problems still pass the
correctness check without them. Some calculations may have negligible impact on the simplified benchmark problem but be very important for other
problems of interest.

Ane example of this is a portion of code in the sweep routines ( source files beginning with 'SweepUCB' ). There is a loop labelled 'TestOppositeFace'
which is designed to provide a higher order of accuracy when running a problem with a less opaque material. The benchmark problems are not impacted by
this code section as their material is fairly opaque, but this code should not be removed as it will impact algorithm accuracy on less opaque material.

Building
========
Expand Down

0 comments on commit 8694a5b

Please sign in to comment.