Fix Cancel Workflows #960
Merged
Fix Cancel Workflows #960
+57
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leahh02
added
WIP
|
I don't have the testing mentioned in Issue #955. I was thinking that should maybe be in a separate PR so this one isn't overwhelming. |
pagrubel
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Good work!
For now if a workflow is cancelled we don't cancel jobs. I like how if all the jobs are already running the workflow continues and is archived once they are completed. And any running jobs are archived. We will need to look at testing and think about how we might want to allow users the option to cancel jobs.
This was referenced Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes cancel workflows. When a workflow was cancelled it ran to completion. Now running or scheduled tasks complete, but new tasks aren't scheduled.