Feat/implement-refresh-tokens #9233
Merged
+123
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laipz8200
force-pushed
the
feat/implement-refresh-tokens
branch
3 times, most recently
from
7d7fcb0
to
cdcac9c
Compare
dosubot
bot
added
size:L
- Introduced `TokenPair` model for managing access and refresh tokens. - Added `refresh_token` method to generate new tokens upon expiration. - Updated login/logout processes to handle token pairs and enhanced security. - Replaced `get_remote_ip` with `extract_remote_ip` for clarity. - Added endpoint for refreshing tokens to maintain user session continuity.
- Streamlined expiration time calculation by separating date arithmetic from payload construction. - Improved code readability and maintainability.
laipz8200
force-pushed
the
feat/implement-refresh-tokens
branch
from
cdcac9c
to
fa67ada
Compare
iamjoel
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Important
Please review the checklist below before submitting your pull request.
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint godsDescription
ACCESS_TOKEN_EXPIRE_MINUTESto.env.examplefiles anddocker-compose.yamlfor setting access token validity.get_account_jwt_tokento use the configured expiration time.OAuthConfigtoAuthConfigto encompass general authentication settings.Fixes
Type of Change
Testing Instructions
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration