Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:support baidu vector db #9185

Merged
merged 6 commits into from
Oct 12, 2024
Merged

feat:support baidu vector db #9185

merged 6 commits into from
Oct 12, 2024

Conversation

WayneCao
Copy link
Contributor

@WayneCao WayneCao commented Oct 10, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Fixes #8592 ; The goal is to add Baidu VectorDB support. Currently, Baidu VectorDB is not included in vector database support. Baidu Vector Database refers to a database system developed by Baidu that is specifically designed to handle and manage vector data efficiently,it's optimized to handle large-scale vector data with high performance and low latency, enabling advanced applications in areas such as natural language processing, computer vision, and personalized recommendations.

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. 👻 feat:rag Embedding related issue, like qdrant, weaviate, milvus, vector database. labels Oct 10, 2024
@WayneCao WayneCao changed the title feat:support baidu vector db #8592 feat:support baidu vector db Oct 10, 2024
@WayneCao WayneCao changed the title feat:support baidu vector db feat:support baidu vector db Closes #8592 Oct 10, 2024
@WayneCao WayneCao changed the title feat:support baidu vector db Closes #8592 feat:support baidu vector db, Closes #8592 Oct 10, 2024
@WayneCao WayneCao changed the title feat:support baidu vector db, Closes #8592 feat:support baidu vector db Oct 10, 2024
api/pyproject.toml Outdated Show resolved Hide resolved
@bowenliang123
Copy link
Contributor

cc @JohnJyong

crazywoola
crazywoola previously approved these changes Oct 12, 2024
Copy link
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 12, 2024
@crazywoola
Copy link
Member

Please resolve the deps

@WayneCao
Copy link
Contributor Author

Please resolve the deps

resolved

@WayneCao WayneCao closed this Oct 12, 2024
@WayneCao WayneCao reopened this Oct 12, 2024
@crazywoola
Copy link
Member

Error: pyproject.toml changed significantly since poetry.lock was last generated. Run `poetry lock [--no-update]` to fix the lock file.

@WayneCao
Copy link
Contributor Author

@crazywoola

Error: pyproject.toml changed significantly since poetry.lock was last generated. Run `poetry lock [--no-update]` to fix the lock file.

sorry, fixed

@crazywoola
Copy link
Member

crazywoola commented Oct 12, 2024

Tests are failed.

@WayneCao
Copy link
Contributor Author

Tests are failed.

fixed, i removed baidu vector db from integration_test, Baidu VectorDB not provide opensource version currently.

@crazywoola crazywoola merged commit 2ec6ffe into langgenius:main Oct 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👻 feat:rag Embedding related issue, like qdrant, weaviate, milvus, vector database. lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support baidu vector db
3 participants