Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(migrations): correct parent_message_id for service-api records #9132

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

laipz8200
Copy link
Collaborator

@laipz8200 laipz8200 commented Oct 9, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

  • Set default parent_message_id to UUID_NIL when it's null for service-api entries post v0.9.0 release.
  • Provide downgrade path to reset parent_message_id back to null in case of rollback.

This PR is a follow-up to #8965. We are updating the parent IDs of all historical messages from service-api to NIL to ensure they can be treated as compatible with older versions of the data.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

- Set default parent_message_id to UUID_NIL when it's null for service-api entries post v0.9.0 release.
- Provide downgrade path to reset parent_message_id back to null in case of rollback.
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🐞 bug Something isn't working labels Oct 9, 2024
@laipz8200 laipz8200 self-assigned this Oct 9, 2024
@laipz8200
Copy link
Collaborator Author

cc @xuzuodong

@xuzuodong
Copy link
Contributor

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 10, 2024
@crazywoola crazywoola merged commit 37d5c16 into main Oct 10, 2024
10 checks passed
@crazywoola crazywoola deleted the fix/add-migration-to-fix-wrong-service-api-history branch October 10, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants