Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RunOnce): prevent sending during IME composition #8459

Closed
wants to merge 1 commit into from

Conversation

MH4GF
Copy link
Contributor

@MH4GF MH4GF commented Sep 15, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

before after
CleanShot.2024-09-15.at.12.36.09.mp4
CleanShot.2024-09-15.at.12.32.42.mp4

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@MH4GF
Copy link
Contributor Author

MH4GF commented Sep 15, 2024

Close because #8460 makes better sense of the solution.

@MH4GF MH4GF closed this Sep 15, 2024
@MH4GF MH4GF deleted the fix-send-on-key-down branch September 15, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Japanese IME Enter key unintentionally submits form in Workflow App
1 participant