Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update clean embedding cache query logic #6483

Merged
merged 6 commits into from
Jul 19, 2024

Conversation

JohnJyong
Copy link
Contributor

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

update clean embedding cache query logic

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@JohnJyong JohnJyong requested a review from takatost July 19, 2024 11:04
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 19, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jul 19, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 19, 2024
@JohnJyong JohnJyong merged commit 1e0e573 into main Jul 19, 2024
9 checks passed
@JohnJyong JohnJyong deleted the fix/embedding-cache-clean-time-too-long branch July 19, 2024 17:29
ZhouhaoJiang added a commit that referenced this pull request Jul 22, 2024
* refs/heads/main: (62 commits)
  fix: extract tool calls correctly while arguments is empty (#6503)
  clean vector collection redis cache (#6494)
  refactor(api): switch to dify_config in controllers/console (#6485)
  update delete embeddings by id (#6489)
  update clean embedding cache query logic (#6483)
  Fix/extra table tracing app config (#6487)
  feat(tool): getimg.ai integration (#6260)
  fix: next suggest question logic problem (#6451)
  fix: build error (#6480)
  fix: correct gpt-4o-mini max token (#6472)
  Update CONTRIBUTING_CN "安装常见问题解答" link. (#6470)
  Update CONTRIBUTING "installation FAQ" link. (#6471)
  Update CONTRIBUTING_JA "installation FAQ" link. (#6469)
  chore: some components upgrage to new ui (#6468)
  fix wrong method using (#6459)
  feat: support gpt-4o-mini for openrouter provider (#6447)
  update ernie models (#6454)
  chore: make text generation timeout duration configurable (#6450)
  refactor(myscale):Set the default value of the myscale vector db in DifyConfig. (#6441)
  [EMERGENCY] Fix Anthropic header issue (#6445)
  ...
cuiks pushed a commit to cuiks/dify that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants