Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add model for 01.ai, yi-chat-34b series #2865

Merged
merged 7 commits into from
Mar 17, 2024

Conversation

soulteary
Copy link
Contributor

@soulteary soulteary commented Mar 17, 2024

Description

support models for 01.ai

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

image image image image

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Mar 17, 2024
@moyudaduizhang
Copy link

As far as I know, the YI series model does not support the adjustment of the parameters of "existence penalty", "frequency penalty", and "reply format".

@soulteary
Copy link
Contributor Author

As far as I know, the YI series model does not support the adjustment of the parameters of "existence penalty", "frequency penalty", and "reply format".

Locally running models support setting duplicate penalty parameters. The online API interface, except for the VL model, should be adapted to OpenAI request parameters, but it is not sure whether :D @moyudaduizhang

Repeat penalty

image image

reply format

image image

@moyudaduizhang
Copy link

moyudaduizhang commented Mar 17, 2024

QQ截图20240317082335
@soulteary I can't rule it out that I missed it, but it's not supported in the documentation,you can see that in the https://platform.lingyiwanwu.com/docs#-%E5%85%A5%E5%8F%82%E6%8F%8F%E8%BF%B0

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Mar 17, 2024
@soulteary
Copy link
Contributor Author

QQ截图20240317082335 @soulteary I can't rule it out that I missed it, but it's not supported in the documentation,you can see that in the https://platform.lingyiwanwu.com/docs#-%E5%85%A5%E5%8F%82%E6%8F%8F%E8%BF%B0

@moyudaduizhang ,I‘ve removed the parameters that were not explicitly supported. hahah

@moyudaduizhang
Copy link

moyudaduizhang commented Mar 17, 2024

QQ截图20240317082335 @soulteary I can't rule it out that I missed it, but it's not supported in the documentation,you can see that in the https://platform.lingyiwanwu.com/docs#-%E5%85%A5%E5%8F%82%E6%8F%8F%E8%BF%B0

@moyudaduizhang ,I‘ve removed the parameters that were not explicitly supported. hahah

(^o^)/~

Copy link
Collaborator

@takatost takatost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm label Mar 17, 2024
@takatost takatost merged commit f770232 into langgenius:main Mar 17, 2024
7 checks passed
@soulteary soulteary deleted the feat/add-model-by-01-ai branch March 19, 2024 16:16
HuberyHuV1 pushed a commit to HuberyHuV1/dify that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants