refactor(ops): Optimize the iteration for filter_none_values and use …

…logging.error to record logs when an exception occurs (#8461)
langgenius · Sep 21, 2024 · 831c5a9 · 831c5a9
1 parent 1a8dcae
commit 831c5a9
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/api/core/ops/entities/trace_entity.py b/api/core/ops/entities/trace_entity.py
@@ -21,8 +21,7 @@ def ensure_type(cls, v):
  return None
  if isinstance(v, str | dict | list):
  return v
- else:
- return ""
+ return ""
 
 
 class WorkflowTraceInfo(BaseTraceInfo):

diff --git a/api/core/ops/ops_trace_manager.py b/api/core/ops/ops_trace_manager.py
@@ -708,7 +708,7 @@ def add_trace_task(self, trace_task: TraceTask):
  trace_task.app_id = self.app_id
  trace_manager_queue.put(trace_task)
  except Exception as e:
- logging.debug(f"Error adding trace task: {e}")
+ logging.error(f"Error adding trace task: {e}")
  finally:
  self.start_timer()
 
@@ -727,7 +727,7 @@ def run(self):
  if tasks:
  self.send_to_celery(tasks)
  except Exception as e:
- logging.debug(f"Error processing trace tasks: {e}")
+ logging.error(f"Error processing trace tasks: {e}")
 
  def start_timer(self):
  global trace_manager_timer

diff --git a/api/core/ops/utils.py b/api/core/ops/utils.py
@@ -6,12 +6,15 @@
 
 
 def filter_none_values(data: dict):
+ new_data = {}
  for key, value in data.items():
  if value is None:
  continue
  if isinstance(value, datetime):
- data[key] = value.isoformat()
- return {key: value for key, value in data.items() if value is not None}
+ new_data[key] = value.isoformat()
+ else:
+ new_data[key] = value
+ return new_data
 
 
 def get_message_data(message_id):