Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add deprecation flag on base upload flow route #4717

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

jordanrfrazier
Copy link
Collaborator

Adds deprecated flag to an old route that I believe is superseded by more specific upload routes like https://github.com/langflow-ai/langflow/blob/deprecate-upload-route/src/backend/base/langflow/api/v1/files.py#L40

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 19, 2024
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 19, 2024
Copy link

codspeed-hq bot commented Nov 19, 2024

CodSpeed Performance Report

Merging #4717 will degrade performances by 95.88%

Comparing deprecate-upload-route (1268592) with main (25a0d76)

Summary

⚡ 1 improvements
❌ 2 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main deprecate-upload-route Change
test_successful_run_with_input_type_any 297.8 ms 218.9 ms +36.03%
test_successful_run_with_output_type_any 219.5 ms 5,326.2 ms -95.88%
test_successful_run_with_output_type_debug 138.8 ms 295.3 ms -53%

@ogabrielluiz ogabrielluiz merged commit e7e364e into main Nov 19, 2024
19 checks passed
@ogabrielluiz ogabrielluiz deleted the deprecate-upload-route branch November 19, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants