Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: simple agent template notes #4709

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

mendonk
Copy link
Collaborator

@mendonk mendonk commented Nov 19, 2024

  • Remove youtube starter template
  • Replace existing simple agent.json with updated readme, description, and key node.
Screenshot 2024-11-19 at 11 28 30 AM

@mendonk mendonk self-assigned this Nov 19, 2024
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Nov 19, 2024
Copy link

codspeed-hq bot commented Nov 19, 2024

CodSpeed Performance Report

Merging #4709 will degrade performances by 26.77%

Comparing fix-simple-agent-template-notes (b31bbec) with main (b978241)

Summary

⚡ 1 improvements
❌ 2 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix-simple-agent-template-notes Change
test_successful_run_with_input_type_any 219.2 ms 299.4 ms -26.77%
test_successful_run_with_input_type_text 217.6 ms 191.3 ms +13.71%
test_successful_run_with_output_type_debug 162.7 ms 216.5 ms -24.86%

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 19, 2024
@ogabrielluiz
Copy link
Contributor

Hey @mendonk

The conflicts are just due to formatting. If you fix them, please run the backend once to make sure the formatting is correct.

@ogabrielluiz
Copy link
Contributor

Hey @mendonk there's probably something wrong with the JSON you added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants