Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding ability for APIRequest to retry and save to a file #4677

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mieslep
Copy link
Contributor

@mieslep mieslep commented Nov 18, 2024

No description provided.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Nov 18, 2024
Copy link

codspeed-hq bot commented Nov 18, 2024

CodSpeed Performance Report

Merging #4677 will degrade performances by 94.76%

Comparing mieslep:phil/api-request (cfc7fa9) with main (a1fa8ec)

Summary

❌ 2 regressions
✅ 13 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main mieslep:phil/api-request Change
test_successful_run_with_output_type_any 271.9 ms 5,187.6 ms -94.76%
test_successful_run_with_output_type_debug 178.1 ms 217.5 ms -18.14%

@erichare erichare self-requested a review November 18, 2024 16:45
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Nov 19, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Nov 19, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 19, 2024
@erichare erichare added the DO NOT MERGE Don't Merge this PR label Nov 19, 2024
@erichare
Copy link
Collaborator

Looks fantastic. Thanks @mieslep . Approving and temporarily marking as DO NOT MERGE as this will go into the release following this week's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Don't Merge this PR enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants