-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: updated node toolbar to be more stable on zoom, fix success and error component tooltips, unselect nodes on flow opening #4610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
This PR changes 100-499 lines, ignoring generated files.
label
Nov 14, 2024
dosubot
bot
added
size:XL
This PR changes 500-999 lines, ignoring generated files.
and removed
size:L
This PR changes 100-499 lines, ignoring generated files.
labels
Nov 14, 2024
anovazzi1
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
deon-sanchez
approved these changes
Nov 15, 2024
This test passes on all other branches so I can't merge this until it is fixed @lucaseduoli |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
javascript
Pull requests that update Javascript code
lgtm
This PR has been approved by a maintainer
size:XL
This PR changes 500-999 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to enhance the user interface, refactor code, and improve the functionality of the
NodeToolbarComponent
and related components. The most important changes include modifications to the scrollbar styles, refactoring of theNodeToolbarComponent
, and updates to theNodeStatus
component.User Interface Enhancements:
src/frontend/src/App.css
: Updated scrollbar styles, including changing the background color of the scrollbar thumb and hover states.Code Refactoring:
src/frontend/src/CustomNodes/GenericNode/index.tsx
: Refactored the toolbar component to use adiv
instead ofNodeToolbar
, and moved the toolbar rendering inside the main node container. [1] [2] [3] [4]src/frontend/src/pages/FlowPage/components/nodeToolbarComponent/index.tsx
: Removed unnecessary zoom scaling logic and replacedSelectContent
withSelectContentWithoutPortal
for better performance. [1] [2] [3] [4] [5]Component Updates:
src/frontend/src/CustomNodes/GenericNode/components/NodeStatus/index.tsx
: Added conditional styling toShadTooltip
and updated the layout and styling of validation messages and run timestamps. [1] [2]Utility and Store Enhancements:
src/frontend/src/stores/flowStore.ts
: AddedunselectAllNodesEdges
utility function to ensure nodes and edges are unselected when updating the flow store. [1] [2]src/frontend/src/utils/reactflowUtils.ts
: Removed unused typeunselectAllNodesType
. [1] [2]Minor Fixes:
src/frontend/src/style/classes.css
: Enabled pointer events for the.react-flow__pane
class.src/frontend/src/pages/FlowPage/components/PageComponent/index.tsx
: EnabledfitView
property for the flow page component.