Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(google-vertexai): fix bug when not using logprobs #7515

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

afirstenberg
Copy link
Contributor

@afirstenberg afirstenberg commented Jan 13, 2025

Fixes #7509

This only explicitly uses logprobs and topLogprobs if logprobs is explicitly set. topLogprobs is only set if logprobs is explicitly true.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 13, 2025
Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Jan 13, 2025 7:34pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Jan 13, 2025 7:34pm

@dosubot dosubot bot added the auto:bug Related to a bug, vulnerability, unexpected error with an existing feature label Jan 13, 2025
@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Jan 13, 2025
@jacoblee93 jacoblee93 merged commit 457c8f2 into langchain-ai:main Jan 13, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PRs that are ready to be merged as-is size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gemini Vertex AI 400 error in recent update
2 participants