Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(langchain-core): Pick runnable config keys in asynclocalstorage #7324

Merged
merged 6 commits into from
Dec 5, 2024
Merged

fix(langchain-core): Pick runnable config keys in asynclocalstorage #7324

merged 6 commits into from
Dec 5, 2024

Conversation

bracesproul
Copy link
Member

@bracesproul bracesproul commented Dec 5, 2024 •
edited
Loading

Moved IterableReadableStreamInterface into types/stream (and re-exported from original location for backwards compat) due to a circular dependency caused by importing the new pickRunnableConfigKeys func inside utils/stream since pickRunnableConfigKeys imports RunnableConfig which is exported from a file which imports IterableReadableStreamInterface

@vercel Vercel
Copy link

vercel bot commented Dec 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 9:40pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Dec 5, 2024 9:40pm

@bracesproul bracesproul requested a review from nfcampos December 5, 2024 21:09
@bracesproul bracesproul removed the request for review from nfcampos December 5, 2024 21:09
@bracesproul bracesproul mentioned this pull request Dec 5, 2024
Merged
@bracesproul bracesproul marked this pull request as ready for review December 5, 2024 21:20
@bracesproul bracesproul requested a review from nfcampos December 5, 2024 21:20
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. auto:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Dec 5, 2024
@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Dec 5, 2024
@bracesproul bracesproul merged commit 217d788 into main Dec 5, 2024
36 checks passed
@bracesproul bracesproul deleted the brace/pick-runable-config-keys branch December 5, 2024 21:43
@bracesproul bracesproul mentioned this pull request Dec 5, 2024
Closed
syntaxsec pushed a commit to aks-456/langchainjs that referenced this pull request Dec 13, 2024
@bracesproul @syntaxsec
fix(langchain-core): Pick runnable config keys in asynclocalstorage (l…
a904b15 
…angchain-ai#7324)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfcampos nfcampos nfcampos approved these changes

Assignees
No one assigned
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PRs that are ready to be merged as-is size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bracesproul @nfcampos