-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add effective_search_ratio to vectorstore #18
Conversation
Vector index returns an ordered list already
V pet., 6. dec. 2024, 11:58 je oseba Alex Thomas ***@***.***>
napisala:
… ***@***.**** commented on this pull request.
------------------------------
In libs/neo4j/langchain_neo4j/vectorstores/neo4j_vector.py
<#18 (comment)>
:
> "YIELD node, score "
+ "WITH node, score LIMIT $k "
Is an ORDER BY not needed here to ensure the nodes with the top k highest
scores are returned?
—
Reply to this email directly, view it on GitHub
<#18 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEYGGTNYJCCJ5Y7DW5TTBZ32EF7NJAVCNFSM6AAAAABTEF4EJCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIOBUGM4DIOJTHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
LGTM @tomasonjo I think the unit tests just need updating. Could you also update the CHANGELOG with the comment below? |
@CodiumAI-Agent /update_changelog |
Changelog updates: 🔄 Added
|
Changelog updates: 🔄 NextAdded
|
effective_search_ratio parameter allows you to improve query accuracy by increasing the potential candidate pool from lucene index and then filtering back down to
k
with Cypher